Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to convert a method with IAsyncEnumerable to IList, ReadOnlySpan, Span #23

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

ValerieFernandes
Copy link

Issue #19

…placements

(chose this design as I thought it could be reusable if other types are given options at any point)
if (IsReplaceWithAttribute(attributeContainingTypeSymbol) && attributeSyntax.Parent?.Parent is ParameterSyntax param
&& GetSymbol(param) is IParameterSymbol parameterSymbol)
{
var variation = parameterSymbol.GetAttributes()[0].NamedArguments.FirstOrDefault(c => c.Key == "Variations").Value.Value;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you're busy with school and there's 0 urgency on this one. Just making a comment to not forget.

[0] is going to grab a wrong attribute if you have something like [Obsolete] in the first position.

@virzak virzak force-pushed the master branch 2 times, most recently from 3dfda17 to b1a312d Compare July 8, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants